Open kmantel opened 4 years ago
With @olchas we encountered the same issue. How can we help to solve this bug?
@jreese is just checking whether leaf.children[-1]
is a Leaf (->store .value
) or Node (store the whole thing?) enough of a fix here, or are there downstream dependencies on this that would break. I suspect any type checking we might have is disabled by using kwargs.
kwargs["annotation"]
seems the way to go. There may be corresponding changes where that's pulled back outtyping.List[str]
in the first postSome getting started docs are at https://github.com/facebookincubator/Bowler/blob/master/CONTRIBUTING.md
@thatch Taking a look at this; first time working with unit tests any documentation on this?
Simple typehints seem to be supported, but others cause bowler to crash. For example,
foo.py:
Running
Produces
While replacing
typing.List[str]
with juststr
produces the expected result