search

facebookincubator / ConversionsAPI-Tag-for-GoogleTagManager

This repository will contain the artifacts needed for setting up Conversions API implementation on Google Tag Manager's serverside. Please follow the instructions https://www.facebook.com/business/help/702509907046774
Apache License 2.0
64 stars 30 forks source link

Allow sending fb_login_id from GA4 Client event model #34

Closed YushengLi closed 1 year ago

YushengLi commented 2 years ago

Scenario

While trying to improve event match rate for our site referencing Best Practices for Conversion API published by Meta Business Help Centre, we've noticed that FB Login ID (App-Scoped ID) is categorized as customer information parameter with Medium priority

And it is also documented in Conversion API Developer documentation

But for now, fb_login_id cannot be submitted with GA4 Client event model, so I mimic how external_id is proxied through GA4 Client event model in order to submit fb_login_id

Tests

I've also run the updated code / tests with GTM environment to ensure everything is still in place.

Screen Shot 2022-05-07 at 1 22 07 AM
facebook-github-bot commented 2 years ago

Hi @YushengLi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

YushengLi commented 1 year ago

Support for Facebook Login ID has been implemented in 8f982c61bff950b83172858a214411e728c9f3e8, this PR is no longer required