search

facebookincubator / GeoLift

GeoLift is an end-to-end geo-experimental methodology based on Synthetic Control Methods used to measure the true incremental effect (Lift) of ad campaign.
https://facebookincubator.github.io/GeoLift/
MIT License
175 stars 54 forks source link

Check that treatment_start_time and treatment_end_time are integers before proceeding with GeoLiftMultiCell. #125

Closed lukasvermeer closed 1 year ago

lukasvermeer commented 1 year ago

I know this change is trivial, but I just lost two hours because I used treatment_start_time = difftime("2022-08-14","2020-10-26") as input for GeoLiftMultiCell and it only complained about this being incorrect after it had completed the model selection step. I hope this addition will save someone else a few hours of waiting.

facebook-github-bot commented 1 year ago

Hi @lukasvermeer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

lukasvermeer commented 1 year ago

Looks like I pushed too quickly and this does not actually work as expected. Pulling the PR.