facebookincubator / GeoLift

GeoLift is an end-to-end geo-experimental methodology based on Synthetic Control Methods used to measure the true incremental effect (Lift) of ad campaign.
https://facebookincubator.github.io/GeoLift/
MIT License
175 stars 54 forks source link

Covariates not working with version 2.7.2 #169

Closed statisticsdave closed 1 year ago

statisticsdave commented 1 year ago

Bug description

The newest version of the package does not load in covariates in the GeoDataRead or GeoLiftMarketSelection functions.

Reproduction steps

step 1: Install packages via

install.packages("remotes", repos='http://cran.us.r-project.org') remotes::install_github("ebenmichael/augsynth") remotes::install_github("facebookincubator/GeoLift")

step 2: Follow geolift walkthrough and load your data w/ covariates.

step3: Call GeoDataRead

GeoTestData_PreTest <- GeoDataRead(data=Gdata, date_id = "COMPLETED_DATE", location_id ="ADJUSTED_STATE", Y_id ="NET_REVENUE", X = c("clicks", "weekend_effect", "cost"), format = "yyyy-mm-dd", summary = TRUE)

Expected behavior

You would expect the new DF to contain the covariates specified. It does not.


Output goes here

## Additional context
I just downloaded the earlier package, and it seemed to work (version 2.6.06)

install.packages("remotes", repos='http://cran.us.r-project.org')
remotes::install_github("ebenmichael/augsynth")
remotes::install_github("facebookincubator/GeoLift", ref= "250af9e")
JussanN commented 1 year ago

Hi @statisticsdave thank you for opening this issue. We're working on to solve it and keep you posted here. In the meantime please use the version 2.6.06 as mentioned in the description in the case you want to include covariates.

JussanN commented 1 year ago

Hi @statisticsdave the problem was fixed. Please update your GeoLift pacakge to the most update version (2.7.4) so you can leverage covariates in the GeoDataRead again. Let us know if you still have any issue regarded this subject. Thank you!

statisticsdave commented 1 year ago

Right on, thanks @JussanN !