Raise error when no markets meet criteria

facebookincubator / GeoLift

GeoLift is an end-to-end geo-experimental methodology based on Synthetic Control Methods used to measure the true incremental effect (Lift) of ad campaign.

https://facebookincubator.github.io/GeoLift/

MIT License

175 stars 54 forks source link

Raise error when no markets meet criteria #192

Open karawoo opened 2 months ago

karawoo commented 2 months ago

Fixes #191

raphaeltamaki commented 1 month ago

Thanks for the PR and please excuse me for the very late review. Much appreaciated

karawoo commented 1 month ago

Thank you for the review! I cannot merge the PR myself as I'm not a collaborator on this repo, so whenever you are ready could you please merge it for me?