Add alpha to GLMS body.

facebookincubator / GeoLift

GeoLift is an end-to-end geo-experimental methodology based on Synthetic Control Methods used to measure the true incremental effect (Lift) of ad campaign.

https://facebookincubator.github.io/GeoLift/

MIT License

182 stars 55 forks source link

Add alpha to GLMS body. #67

Closed NicolasMatrices-v2 closed 2 years ago

NicolasMatrices-v2 commented 2 years ago

Is your feature request related to a problem? Please describe.

The argument alpha in GeoLiftMarketSelection() is not used in the function body. I would like to know if you plan to use it as the threshold to decide the significant column or it will not be used in the future?

Describe the solution you'd like

Add alpha within the GLMS body.

Additional context

Thanks @yulisong

NicolasMatrices-v2 commented 2 years ago

Addressed in the linked PR. Closing this issue.