search

facebookincubator / SocketRocket

A conforming Objective-C WebSocket client library.
Other
9.56k stars 2.01k forks source link

Error ITMS-90056: Info.plist file is missing the required key: CFBundleVersion #500

Open dstarke opened 7 years ago

dstarke commented 7 years ago

When built from master, the framework cannot be included in an app store submission. ITMS returns the error ITMS-90056 and reports that the Info.plist file is missing the CFBundleVersion key.

It looks like this may be caused by an earlier change that updated all the targets to use shared configurations. Prior to that, the build configurations set a CURRENT_PROJECT_VERSION build variable (it was set to 1), and the Info.plist sets the CFBundleVersion to the value of that build variable. However, the .xcconfig files do not set CURRENT_PROJECT_VERSION, so the built framework's CFBundleVersion is empty.

There are two easy fixes: either update the configurations to set CURRENT_PROJECT_VERSION, or update the Info.plist so that CFBundleVersion is set to a valid value instead of $(CURRENT_PROJECT_VERSION)

Droppix commented 7 years ago

+1

RickOHara commented 7 years ago

+1

hatdragon commented 7 years ago

+1

SjoerdPerfors commented 7 years ago

+10

lswith commented 7 years ago

+1

WFNeIn commented 7 years ago

I set it but it doesn't work. it is still report same error

dzenbot commented 6 years ago

++

sanoj00b commented 6 years ago

+1 I am facing exact same issue. Did anybody resolve this issue?

dzenbot commented 6 years ago

We are checking out the commit in https://github.com/facebook/SocketRocket/pull/535 that fixes this issue.

sanoj00b commented 6 years ago

@dzenbot I am pointing to master currently but still I am facing same issue. Is that fix is not yet merged? ERROR ITMS-90056: "This bundle Payload/MyApp.app/Frameworks/SocketRocket.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion."

dzenbot commented 6 years ago

It's is a regression in master. You should check the commit from the PR I posted.

sanoj00b commented 6 years ago

@dzenbot That PR (https://github.com/facebook/SocketRocket/pull/535) is open or are you referring any other one? please mention the commit id. Please let me know. I am blocked and cant push the app to app store.

sanoj00b commented 5 years ago

@ I resolved it by adding the missing version created framework by Carthage.