search

facebookincubator / SocketRocket

A conforming Objective-C WebSocket client library.
Other
9.56k stars 2.01k forks source link

Adding bearer authentication support #501

Closed tmughal closed 7 years ago

tmughal commented 7 years ago

This commit adds support for bearer authentication during the WebSocket handshake request.

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

gaming-hacker commented 6 years ago

@ tmughal nice patch. to stop the compiler from complaining that the self could be nil. i also changed this delegate to a strong reference but you could probably make it weak and handle it

@property (nonatomic, strong) id <SRWebSocketAuthenticationDelegate> authenticationDelegate;

tmughal commented 6 years ago

@gaming-hacker Glad it was useful