facebookincubator / SocketRocket

A conforming Objective-C WebSocket client library.
Other
9.54k stars 2.01k forks source link

Carthage build #521

Open uspasojevic96 opened 7 years ago

uspasojevic96 commented 7 years ago

After adding github "facebook/SocketRocket" to the Cartfile and running carthage update it produces this error:

Cloning SocketRocket Checking out SocketRocket at "0.5.1" xcodebuild output can be found in /var/folders/zf/46rkznm14ysfd3c0q71p49nm0000gn/T/carthage-xcodebuild.FPLGZY.log Building scheme "SocketRocketOSX" in SocketRocket.xcodeproj Build Failed Task failed with exit code 65: /usr/bin/xcrun xcodebuild -project /Users/uros/devel/ios/Carthage/Checkouts/SocketRocket/SocketRocket.xcodeproj -scheme SocketRocketOSX -configuration Release -derivedDataPath /Users/uros/Library/Caches/org.carthage.CarthageKit/DerivedData/SocketRocket/0.5.1 ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/zf/46rkznm14ysfd3c0q71p49nm0000gn/T/carthage-xcodebuild.FPLGZY.log

suriksarkisyan commented 7 years ago

@uspasojevic96, i have same issue. Before it will be fixed you can try to use previous versions by adding something like github "facebook/SocketRocket" == 0.4.2 or github "facebook/SocketRocket" == 0.4.1 in your Cartfile This is not best solution but it works.

brokaw commented 7 years ago

I found that if you build off the master branch it works. I put this in my Cartfile

github "facebook/SocketRocket" "master"

and ran carthage update and it successfully built three targets.

If you leave off any version or branch, like this

github "facebook/SocketRocket"

it grabs 0.5.1, which breaks with the automatic Carthage build.

linked67 commented 6 years ago

The master branch in carthage works but i have to edit the info.plist and enter myself a version number to send it to the Apple store. I must edit the info.plist on each carthage update, it's a real pain...

stonedauwg commented 6 years ago

Any update on if this will be fixed?

linked67 commented 6 years ago

Bump