search

facebookincubator / SocketRocket

A conforming Objective-C WebSocket client library.
Other
9.56k stars 2.01k forks source link

Fix for #500 #535

Closed lswith closed 1 year ago

lswith commented 7 years ago

This fixes the issue #500

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

jimocallaghan commented 6 years ago

Is there a chance this PR will get merged? We're facing the same issue - need some of the other post r0.4.2 fixes also and without this are getting bounced on iTunes upload with ITMS-90056 - "The Info.plist file is missing the required key: CFBundleVersion."

dzenbot commented 6 years ago

This issue is now blocking the submission to the AppStore. image

Please merge this change soon.

iandundas commented 6 years ago

Please can this be merged soon.

dzenbot commented 6 years ago

cc @nlutsenko

dzenbot commented 6 years ago

The build error on Travis is unrelated to this change FWIW. Someone with access needs to trigger a rebuild.