search

facebookincubator / SocketRocket

A conforming Objective-C WebSocket client library.
Other
9.54k stars 2.01k forks source link

fix the data race about 'readyState' #582

Open YYDD opened 6 years ago

YYDD commented 6 years ago

set the property readyState in the _workQueue thread. get property readyState some in main thread, and some in the same thread where set.

So it causes data racing,when set in _workQueue thread and get in main thread.

I met several times in - (void)open. So change the geting in _workQueuethread.

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!