search

facebookincubator / SocketRocket

A conforming Objective-C WebSocket client library.
Other
9.54k stars 2.01k forks source link

Mkirk/handle sec err #584

Closed michaelkirk-signal closed 1 year ago

michaelkirk-signal commented 6 years ago

Cleanup and address some TODO's around random generation.

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

michaelkirk-signal commented 6 years ago

Ok this is ready for review.

...

I filled out the CLA in the period while the PR was closed... not sure if the CLA bot will catch it, but let me know if you need me to do anything else.

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

nlutsenko commented 1 year ago

Wonderful! Thank you!