search

facebookincubator / SocketRocket

A conforming Objective-C WebSocket client library.
Other
9.54k stars 2.01k forks source link

Fix Basic Authorization header #617

Closed ElfSundae closed 1 year ago

ElfSundae commented 5 years ago

Currently the Basic Authorization header is always added.

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

sergeymild commented 2 years ago

When it will be merged?

ElfSundae commented 2 years ago

@sergeymild You might use my fork https://github.com/ElfSundae/SocketRocket Changes: https://github.com/facebookincubator/SocketRocket/compare/main...ElfSundae:master

CocoaPods installation:

pod 'SocketRocket', :git => 'https://github.com/ElfSundae/SocketRocket.git'

Or:

pod 'SocketRocket', :source => 'https://github.com/ElfSundae/CocoaPods-Specs.git'
sergeymild commented 2 years ago

@sergeymild You might use my fork https://github.com/ElfSundae/SocketRocket Changes: main...ElfSundae:master

CocoaPods installation:

pod 'SocketRocket', :git => 'https://github.com/ElfSundae/SocketRocket.git'

Or:

pod 'SocketRocket', :source => 'https://github.com/ElfSundae/CocoaPods-Specs.git'

i can't use your fork, because i use it in a pod library, and as we know you can't use libraries from github they must be present in cocoapods repository(((

robinmaree commented 1 year ago

Would be great if this can be merged, happy to help testing if needed!

efstathiosntonas commented 1 year ago

This PR fixes this issue on react-native@0.72.x:

https://github.com/facebook/react-native/issues/38012