search

facebookincubator / below

A time traveling resource monitor for modern Linux systems
Apache License 2.0
1.04k stars 60 forks source link

Document `cgroup_root` config option #8179

Closed danobi closed 1 year ago

danobi commented 1 year ago

This is a useful config to document b/c many systems are still running under the (rather weird) hybird cgroup1 and cgroup2 system (ie. /sys/fs/cgroup/unified for cgroup2 and /sys/fs/cgroup for cgroup1).

On hybrid systems, it is useful to set cgroup_root to the unified mountpoint as a stopgap to make below run.

danobi commented 1 year ago

It looks like the following are still undocumented:

    pub enable_gpu_stats: bool,
    pub enable_btrfs_stats: bool,
    pub btrfs_samples: u64,
    pub btrfs_min_pct: f64,

I can't really guess what the last two do but it'd be good if someone familiar could document all 4.

facebook-github-bot commented 1 year ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

brianc118 commented 1 year ago

Thanks Daniel. Unfortunately those other 4 do nothing in open source, and we couldn't think of a way to hide them easily.

danobi commented 1 year ago

Ah ok. That's fine then. Thanks Brian.

facebook-github-bot commented 1 year ago

@brianc118 merged this pull request in facebookincubator/below@6006ae2975b4fee0135a1ef978c41f77132a381e.