Closed danobi closed 1 year ago
@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
All my comments are of the pretty minor variety. This all looks great. Once the inline-comments are addressed we can import on our end
I've addressed the review changes in fixup commits so it's easier to see the delta. Just lemme know if you want me to git rebase --autosquash
it.
Thanks, this all looks good to me - not need to squash, we'll import on our end
@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@brianc118 merged this pull request in facebookincubator/below@895770a8136e21cadd7847f9fb7c615069cd79b8.
As promised, here is support for dumping in OpenMetrics format. I did my best to structure the commits so it's more easily reviewed, but here are some salient points: