facebookincubator / below

A time traveling resource monitor for modern Linux systems
Apache License 2.0
1.04k stars 60 forks source link

Add support for dumping in OpenMetrics format #8186

Closed danobi closed 1 year ago

danobi commented 1 year ago

As promised, here is support for dumping in OpenMetrics format. I did my best to structure the commits so it's more easily reviewed, but here are some salient points:

facebook-github-bot commented 1 year ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dschatzberg commented 1 year ago

All my comments are of the pretty minor variety. This all looks great. Once the inline-comments are addressed we can import on our end

danobi commented 1 year ago

I've addressed the review changes in fixup commits so it's easier to see the delta. Just lemme know if you want me to git rebase --autosquash it.

dschatzberg commented 1 year ago

Thanks, this all looks good to me - not need to squash, we'll import on our end

facebook-github-bot commented 1 year ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@brianc118 merged this pull request in facebookincubator/below@895770a8136e21cadd7847f9fb7c615069cd79b8.