search

facebookincubator / below

A time traveling resource monitor for modern Linux systems
Apache License 2.0
1.08k stars 61 forks source link

Add clang-15+ prerequisite to README #8203

Closed mmynk closed 1 year ago

mmynk commented 1 year ago

Multiple issues (#8112, #8195) have been created related to build errors because the build isn't using clang-15 or greater.

danobi commented 1 year ago

Place that in https://github.com/facebookincubator/below/blob/main/docs/building.md instead?

mmynk commented 1 year ago

Makes sense (hoping people would read that before trying to build).

facebook-github-bot commented 1 year ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

brianc118 commented 1 year ago

Yeah like Daniel said, let's add it to the dependencies section in building.md and also update the build instructions at the bottom.

facebook-github-bot commented 1 year ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@brianc118 merged this pull request in facebookincubator/below@6d3392da6c97465c28f96c24b6f7e3774f6329a2.