facebookincubator / below

A time traveling resource monitor for modern Linux systems
Apache License 2.0
1.08k stars 61 forks source link

Show per-cpu fields for `system` when `--detail` is set #8208

Closed mmynk closed 1 year ago

mmynk commented 1 year ago

For --detail and --everything, below dump system... shows aggregated view over all the CPUs. The change is to show per-CPU details when queried with --detail or --everything flag.

Before:

# TYPE system_cpu_softirq_pct gauge
system_cpu_softirq_pct{cpu="-1",hostname="ip-172-31-24-129"} 0 1696365681
# TYPE system_cpu_softirq_pct gauge
system_cpu_softirq_pct{cpu="-1",hostname="ip-172-31-24-129"} 0 1696365685

After:

# TYPE system_cpus_0_softirq_pct gauge
system_cpus_0_softirq_pct{cpu="0",hostname="ip-172-31-24-129"} 0 1696365580
# TYPE system_cpus_1_softirq_pct gauge
system_cpus_1_softirq_pct{cpu="1",hostname="ip-172-31-24-129"} 0.199203187250996 1696365580
# TYPE system_cpus_0_softirq_pct gauge
system_cpus_0_softirq_pct{cpu="0",hostname="ip-172-31-24-129"} 0 1696365585
# TYPE system_cpus_1_softirq_pct gauge
system_cpus_1_softirq_pct{cpu="1",hostname="ip-172-31-24-129"} 0 1696365585
facebook-github-bot commented 1 year ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mmynk commented 1 year ago

@brianc118 not sure why the last build failed, it was just a rustfmt change might help to re-run the CI? or i can do a dummy push.

brianc118 commented 1 year ago

Yeah not sure what happened there. I just triggered a rerun.

facebook-github-bot commented 1 year ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@brianc118 merged this pull request in facebookincubator/below@c2644234f62a98f168e4e24a476937657cdf6403.