Closed mmynk closed 7 months ago
@brianc118 Could you take a look at the PR again? Thanks!
@brianc118 not sure if you got a chance to read my last comment regarding the implementation of maj:min
identifier for qdiscs: https://github.com/facebookincubator/below/pull/8210#discussion_r1550174837
I think that's the only remaining part for this PR. I'll add README in the meanwhile.
@brianc118 added README and refactored the fq_codel
xstats definition. Could you please take another look?
I will refactor TcModel
to be uniquely identifiable in a subsequent PR. Thanks!
@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@brianc118 fixed the lint issues, for some reason the test seems to be running for over a day, would re-triggering help? regardless, could you please re-import to trigger the linter again? thanks!
@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@mmynk don't worry about the internal tests. I suspect the test hook isn't working as expected.
@brianc118 is the PR okay to be merged? just wanted to make sure if there is something I need to fix (lint or test). thanks!
@mmynk I was just working on vendoring the netlink-* crates internally which proved to be a pain. Expect to have this merged in the next few days.
@mmynk I was just working on vendoring the netlink-* crates internally which proved to be a pain.
Oh shoot! I wish I could help with that.
Expect to have this merged in the next few days.
Great, thanks for letting me know.
@brianc118 merged this pull request in facebookincubator/below@4acd7488eaea9147cd879b41ff9826dd8a45a52b.
tc
statsnetlink-packet-route
library which readsqdisc
s via rtnetlinkResult: