Make `ethtool` optional in sample

facebookincubator / below

A time traveling resource monitor for modern Linux systems

Apache License 2.0

1.01k stars 59 forks source link

Make `ethtool` optional in sample #8211

Closed mmynk closed 8 months ago

mmynk commented 8 months ago

This makes sure newer versions of below play nicely with older.

Currently, on using newer version of below to parse snapshots recorded by earlier versions, it fails with error:

Nov 03 03:29:23.169 WARN Failed to deserialize data frame: missing field `ethtool`
Nov 03 03:29:23.170 WARN Failed to deserialize data frame: missing field `ethtool`
...

This change makes sure, error isn't thrown and ethtool is set as None in the sample.

facebook-github-bot commented 8 months ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 8 months ago

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 8 months ago

@brianc118 merged this pull request in facebookincubator/below@22d9b418c9d6e1cdb10749c57e97578241b055f1.