facebookincubator / cinder

Cinder is Meta's internal performance-oriented production version of CPython.
https://trycinder.com
Other
3.43k stars 122 forks source link

error: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead #11

Closed alexdoesh closed 3 years ago

alexdoesh commented 3 years ago

./oss-build-and-test.sh output (Ubuntu 20.04):

/home/dev/experiments/cinder/Modules/signalmodule.c: In function ‘signal_siginterrupt_impl’:
/home/dev/experiments/cinder/Modules/signalmodule.c:661:5: error: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Werror=deprecated-declarations]
  661 |     if (siginterrupt(signalnum, flag)<0) {
      |     ^~
In file included from /home/dev/experiments/cinder/Modules/signalmodule.c:26:
/usr/include/signal.h:311:12: note: declared here
  311 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
gcc -pthread -I"/home/dev/experiments/cinder" -fno-omit-frame-pointer -momit-leaf-frame-pointer  -Wno-unused-result -Wsign-compare -Wno-cast-function-type -Wno-type-limits -DNDEBUG -g -fwrapv -O3 -Wall    -std=c99 -Wextra -Werror -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration  -I/home/dev/experiments/cinder/Include/internal -I"/home/dev/experiments/cinder" -IObjects -IInclude -IPython -I. -I/home/dev/experiments/cinder/Include -I/home/dev/experiments/cinder/ThirdParty/fmt-6.1.1/include -I/home/dev/experiments/cinder/ThirdParty/i386-dis   -DFMT_HEADER_ONLY=1  -DPy_BUILD_CORE_BUILTIN  -c /home/dev/experiments/cinder/Modules/_stat.c -o Modules/_stat.o
cc1: all warnings being treated as errors
make: *** [Makefile:2431: Modules/signalmodule.o] Error 1
make: *** Waiting for unfinished jobs....
mpage commented 3 years ago

This should be fixed by https://github.com/facebookincubator/cinder/commit/026757bb17bb4a0b930b8aff719b1a7070e60239.