search

facebookincubator / cinder

Cinder is Meta's internal performance-oriented production version of CPython.
https://trycinder.com
Other
3.42k stars 122 forks source link

Build and copy _cinderx and cinderx in Dockerfile #133

Closed tekknolagi closed 3 months ago

tekknolagi commented 5 months ago

This at least builds _cinderx.so (which wasn't being built before) and bundles cinderx into the installed lib/, but currently fails to import _cinderx with:

>>> import cinderx
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/max/Documents/code/cinder/dst/lib/python3.10/cinderx/__init__.py", line 12, in <module>
    from _cinderx import (
ImportError: /home/max/Documents/code/cinder/dst/lib/python3.10/_cinderx.cpython-310-x86_64-linux-gnu.so: undefined symbol: crc32

Which I don't know how to solve yet.

tekknolagi commented 5 months ago

@jbower-fb thoughts?

carljm commented 5 months ago

cc @pilleye this is in the direction of fixing trycinder.com

pilleye commented 3 months ago

Fixed with a594bc44ba4d4a0eb0d87edbc1f41e001210c6ba and f3f3a46a2227f78f22fd3b55400066a46b12ccb3.

tekknolagi commented 3 months ago

Woooo! Thanks, @pilleye !

pilleye commented 3 months ago

@tekknolagi it was basically all this PR, so thank you for the pointers! I think you just needed to build the Dockerfile with --platform linux/amd64, but I didn't verify that this was the issue.

pilleye commented 3 months ago

Will look into the new failures later :'(