search

facebookincubator / cinder

Cinder is Meta's internal performance-oriented production version of CPython.
https://trycinder.com
Other
3.42k stars 122 forks source link

Outdated instructions in python-build-env? #136

Closed mrigankpawagi closed 1 month ago

mrigankpawagi commented 1 month ago

static-python doesn't have the compiler in the most recent commit. (compiler.py is available inside cinderx but there are errors in the module if it is forcefully included in sys.path). I am referring to this.

jbower-fb commented 1 month ago

You are right, those instructions are now out of date and indeed the compiler has moved into the cinderx/ directory. What are you trying to do though? I don't understand why you need to manually put it in your sys.path.

mrigankpawagi commented 1 month ago

Thanks for your response, @jbower-fb. I cannot run ./python -m compiler --static module.py. Is this something I do not need to do anymore?

bennn commented 1 month ago

@jbower-fb we just want to use static python, e.g. to run benchmarks like deltablue https://github.com/facebookincubator/cinder/blob/cinder/3.10/Tools/benchmarks/deltablue_static.py

jbower-fb commented 1 month ago

Ah, you now need to run:

$ ./python -m cinderx.compiler --static module.py
mrigankpawagi commented 1 month ago

Thanks a lot @jbower-fb! Should've noticed this! I will close this issue for now.