defunct "-X shadowbytecode" referenced by Makefile?

facebookincubator / cinder

Cinder is Meta's internal performance-oriented production version of CPython.

https://trycinder.com

Other

3.49k stars 121 forks source link

defunct "-X shadowbytecode" referenced by Makefile? #20

Closed belm0 closed 3 years ago

belm0 commented 3 years ago

I noticed this during a PGO build. Perhaps "-X shadowbytecode" is a remnant from when shadow bytecode needed to be explicitly enabled? I don't see a reference to this option in the source code or docs.

https://github.com/facebookincubator/cinder/blob/afb637523d5f0fdd358a047ebe02a0cafa6f3403/Makefile.pre.in#L287

jbower-fb commented 3 years ago

Looks dead to me too. I'll put up a PR internally removing it and see if anyone complains.

belm0 commented 3 years ago

removed in https://github.com/facebookincubator/cinder/commit/601512fbcb7f1e003e13dbac10bfe973786879fc