facebookincubator / cinder

Cinder is Meta's internal performance-oriented production version of CPython.
https://trycinder.com
Other
3.49k stars 121 forks source link

[oss] Fix OSS build #91

Closed czardoz closed 1 year ago

czardoz commented 2 years ago

By adding -lrt to the interpreter build.

Tested this locally.

Without the change:

>> python
/usr/bin/ld: libpython3.10_static.a(virtmem.o): in function `asmjit::VirtMem_openAnonymousMemory(int*, bool)':
/vol/ThirdParty/asmjit/src/asmjit/core/virtmem.cpp:330: undefined reference to `shm_open'
/usr/bin/ld: libpython3.10_static.a(virtmem.o): in function `VirtMem_openAnonymousMemory':
/vol/ThirdParty/asmjit/src/asmjit/core/virtmem.cpp:332: undefined reference to `shm_unlink'
collect2: error: ld returned 1 exit status

After this change:

Python build finished successfully!
The necessary bits to build these optional modules were not found:
_dbm                  _gdbm                 _tkinter           
_uuid                 nis                                      
To find the necessary bits, look in setup.py in detect_modules() for the module's name.

The following modules found by detect_modules() in setup.py, have been
built by the Makefile instead, as configured by the Setup files:
_abc                  pwd                   time               
facebook-github-bot commented 2 years ago

@czardoz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jbower-fb commented 1 year ago

Looks like this has made it into the repo from another source.