search

facebookincubator / dhcplb

dhcplb is Facebook's implementation of a load balancer for DHCP.
MIT License
1.05k stars 90 forks source link

Explicitly include receipes after go parameters definition #16

Closed lsiudut closed 7 years ago

lsiudut commented 7 years ago

For some reason it didn't work for me unless I explicitly included go recipes in dhcplb cookbook recipe. Chef was trying to launch dhcplp before even go was installed in system, not mentioning compiling the project.

After applying this patch everything works as expected, vagrant up finishes successfully.

root 7760 0.0 0.8 131268 4168 ? Ssl 09:42 0:00 /opt/go/bin/dhcplb -version 4 -config /home/vagrant/dhcplb.config.json

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 7 years ago

@pallotron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.