fix lint: remove sync pool

facebookincubator / dhcplb

dhcplb is Facebook's implementation of a load balancer for DHCP.

MIT License

1.05k stars 90 forks source link

Closed pmazzini closed 2 years ago

pmazzini commented 2 years ago

Lint warns about extra allocations being done due to the way sync.Pool is being used: https://deepsource.io/gh/beego/beego/issue/SCC-SA6002/occurrences

I don't think we need sync.Pool at all. The public NTP infra doesn't do this and it is scaling well: https://github.com/facebook/time/blob/main/ntp/responder/server/server.go#L160

facebook-github-bot commented 2 years ago

@pmazzini has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.