search

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
227 stars 34 forks source link

remove `getpid` and `gettid` functions #141

Closed jordalgo closed 1 year ago

jordalgo commented 1 year ago

Summary: Original diff: D44921379

Aside from the fact that getpid wasn't returning the right thing, ifndef doesn't work for function declaration checking.

https://stackoverflow.com/questions/6234755/does-ifdef-or-other-preprocessor-directives-work-for-function-declarations-t

This is breaking Strobelight filtering, which is how I found this.

Reviewed By: nslingerland, hodgesds

Differential Revision: D46303472

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46303472

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46303472

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46303472

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46303472

facebook-github-bot commented 1 year ago

This pull request has been merged in facebookincubator/dynolog@2a09bfe4bec9751d6665f02fa40f4c5c9f844531.