facebook-github-bot
commented
1 year ago Hi @shradhasehgal!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Summary:
pytorch_profiler.mdto include information about older PyTorch versions.Based on this thread, versions below PyTorch 2.0 do not work with the on-demand remote tracing feature in Dynolog.
It would be fruitful to mention this in the README - currently, we only mention that the latest PyTorch 2.0 release is recommended, and nothing about the older versions.
Since using Dynolog with an older PyTorch version does not result in any kind of error or warning, it may be confusing to the users as to why they don't see the expected functionality. Thus, we can include this in the README since many still use older torch versions.