search

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
260 stars 38 forks source link

Replace memcmp with checked_memcmp #177

Closed briancoutinho closed 1 year ago

briancoutinho commented 1 year ago

Summary: No behavior change expected other than: A out-of-cound buffer access is now an abort. Looking at the code this should not have been a possibility, but a future change in the type names, or the type buffer size could have exposed an issue.

Differential Revision: D44138204

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D44138204

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D44138204

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D44138204

facebook-github-bot commented 1 year ago

This pull request has been merged in facebookincubator/dynolog@8727c9310e74a52e14d579fb21d71b600f501108.