search

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
188 stars 34 forks source link

Remove extraneous semicolon from hbt/src/tagstack/Slicer.h #190

Closed r-barnes closed 6 months ago

r-barnes commented 7 months ago

Summary: Extraneous semicolons are a code smell and can mask more serious problems. -Wextra-semi-stmt finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow many other files to take advantage of the safety -Wextra-semi-stmt offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering

Differential Revision: D51631119

facebook-github-bot commented 7 months ago

This pull request was exported from Phabricator. Differential Revision: D51631119

facebook-github-bot commented 6 months ago

This pull request has been merged in facebookincubator/dynolog@e4de72f37f4dd0f4fa7b49de0d2f3565c3ecd5df.