search

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
188 stars 34 forks source link

Remove unused exception parameter from files inc graphene/ticket/test/fuzz/GrapheneTicketFromStringFuzzer.cpp #205

Closed r-barnes closed 6 months ago

r-barnes commented 6 months ago

Summary: -Wunused-exception-parameter has identified an unused exception parameter. This diff removes it.

This:

try {
    ...
} catch (exception& e) {
    // no use of e
}

should instead be written as

} catch (exception&) {

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D51977657

facebook-github-bot commented 6 months ago

This pull request was exported from Phabricator. Differential Revision: D51977657

facebook-github-bot commented 6 months ago

This pull request has been merged in facebookincubator/dynolog@f1b62928c4afbb9c58ab835b5f8de89dbf286667.