search

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
188 stars 34 forks source link

Fix shadowed variable in hbt/src/perf_event/PmuEvent.h #209

Closed r-barnes closed 5 months ago

r-barnes commented 5 months ago

Summary: Our upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a high bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.

This codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.

What's a shadowed variable?

Shadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.

This diff fixes such an issue by renaming the variable.

Reviewed By: palmje

Differential Revision: D52582917

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D52582917

facebook-github-bot commented 5 months ago

This pull request has been merged in facebookincubator/dynolog@2d7180de47a7157457b0c954b9e510bf138b8503.