search

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
188 stars 34 forks source link

Remove unused variables in hbt/src/perf_event/PmuDevices.cpp #218

Closed r-barnes closed 5 months ago

r-barnes commented 5 months ago

Summary: LLVM-15 has a warning -Wunused-but-set-variable which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with [[maybe_unused]], mostly in cases where the variable is used, but, eg, in an assert statement that isn't present in production code.

Reviewed By: bunnypak, dmm-fb

Differential Revision: D53011652

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D53011652

facebook-github-bot commented 5 months ago

This pull request has been merged in facebookincubator/dynolog@02be8efefd00a9ba0409cfb49e4bb84a5831dac9.