Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
260
stars
38
forks
source link
Remove unused variables in hbt/src/tagstack/Slicer.h #219
Summary:
LLVM-15 has a warning -Wunused-but-set-variable which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.
This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with [[maybe_unused]], mostly in cases where the variable is used, but, eg, in an assert statement that isn't present in production code.
If you approve of this diff, please use the "Accept & Ship" button :-)
Summary: LLVM-15 has a warning
-Wunused-but-set-variable
which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with
[[maybe_unused]]
, mostly in cases where the variable is used, but, eg, in anassert
statement that isn't present in production code.Reviewed By: bunnypak, dmm-fb
Differential Revision: D53011660