Fix deprecated use of 0/NULL in gloo2/rendezvous/tcp_utils.cc + 3

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.

MIT License

260 stars 38 forks source link

Fix deprecated use of 0/NULL in gloo2/rendezvous/tcp_utils.cc + 3 #227

Closed r-barnes closed 6 months ago

r-barnes commented 7 months ago

Summary: nullptr is typesafe. 0 and NULL are not. In the future, only nullptr will be allowed.

This diff helps us embrace the future now in service of enabling -Wzero-as-null-pointer-constant.

Reviewed By: meyering

Differential Revision: D54163052

facebook-github-bot commented 7 months ago

This pull request was exported from Phabricator. Differential Revision: D54163052

bigzachattack commented 6 months ago

Merged in e92437c