ignore rather than crash when uncore device has empty cpu_mask

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.

MIT License

187 stars 34 forks source link

ignore rather than crash when uncore device has empty cpu_mask #239

Closed Alston-Tang closed 3 months ago

Alston-Tang commented 3 months ago

Summary: it's fine if we are unable to collect perf metrics from some PMUs (possible reason could be the numa node is offlined). ignore opening perf metric for empty cpu_mask rather than crash dynolog

Differential Revision: D55105429

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D55105429

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D55105429

facebook-github-bot commented 3 months ago

This pull request has been merged in facebookincubator/dynolog@20638afe1b03b440e5e9e75f31f2fedde395374a.