search

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
187 stars 34 forks source link

read uncore values per perf evnet #243

Closed Alston-Tang closed 3 months ago

Alston-Tang commented 3 months ago

Summary: perPerfEventsGroupBase::read() function accumulate ReadValues from different CPU core or uncore PMU by summing accumulated running time/enabled time/raw count together. This sometimes is not expected when people want to calculate the sum of the kernel multiplexing adjusted value.

to avoid using perPerfEventsGroupBase::read() function in PerfCountMangerHbt, a new function readPerPerfEventsGroup() is added. it will return a list of ReadValues, one from each perf event. In this way, we can choose how to aggregate values from different perf events later in dynolog.

Reviewed By: bigzachattack

Differential Revision: D55400965

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D55400965

facebook-github-bot commented 3 months ago

This pull request has been merged in facebookincubator/dynolog@5d42ea97a9b6461a161bce74dea9641763688340.