search

facebookincubator / dynolog

Dynolog is a telemetry daemon for performance monitoring and tracing. It exports metrics from different components in the system like the linux kernel, CPU, disks, Intel PT, GPUs etc. Dynolog also integrates with pytorch and can trigger traces for distributed training applications.
MIT License
256 stars 37 forks source link

GPL-3.0 license detected in a third_party file #278

Closed jamesjordan522 closed 2 days ago

jamesjordan522 commented 1 month ago

This issue was originally reported here: https://github.com/pytorch/pytorch/issues/132151

dynolog is currently distributed under the MIT license, however a GPL-v3 file is part of the third party tool 'cpr', see third_party/cpr/test/LICENSE

Can this issue be resolved?

jamesjordan522 commented 1 week ago

Further research showed, that dynolog uses

add_subdirectory(third_party/cpr)
target_link_libraries(dynolog_lib PUBLIC cpr::cpr)

in its CMakeLists.txt.

In cpr's CMakeLists.txt the CPR_BUILD_TESTS flag is set to OFF by default.

Consequently, it seems like building dynolog is not affected by this GPL license. Can anyone confirm this?

briancoutinho commented 2 days ago

@jamesjordan522 thank you so much for checking the details. I can confirm we do not run tests for CPR in our build flow. If required I can explicitly add it in the CMakeLists.txt as well.

https://github.com/facebookincubator/dynolog/blob/main/CMakeLists.txt#L54-L58

Closing this issue for now but please feel free to re-open.