search

facebookincubator / fastmod

A fast partial replacement for the codemod tool
Apache License 2.0
1.66k stars 41 forks source link

Add a thread count option #18

Closed gsquire closed 4 years ago

gsquire commented 4 years ago

This PR adds an option to configure the amount of threads that the directory iterator will use. It doesn't close any issues but rather removes a "TO DO" left in the code.

swolchok commented 4 years ago

What's your use case for specifying the number of threads? I want to make sure someone actually needs this change.

gsquire commented 4 years ago

What's your use case for specifying the number of threads?

I don't have a specific one. It was just a patch for the old TODO comment I saw.

Edit: Feel free to close this patch too if you want to table the feature for now.

swolchok commented 4 years ago

First of all, let me apologize for not asking about the use case up front. Sorry about that.

I think that we should table this feature until there is demand for it from users. Thanks for implementing it!