search

facebookincubator / fastmod

A fast partial replacement for the codemod tool
Apache License 2.0
1.66k stars 41 forks source link

Add release workflow using GitHub Actions #19

Closed ngirard closed 4 years ago

ngirard commented 4 years ago

This workflow is the same as @lunaryorn's Mdcat -- kudos to him !

It is triggered when a release is created with a tag named 'v something', e.g. v1.1.0.

You can see the results on my own fork here.

The 3 builds for Linux, MacOS and Windows run fine, but I've only tested the Linux one.

This PR also creates a CHANGELOG.md file, to be included in the released packages.

facebook-github-bot commented 4 years ago

Hi @ngirard!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

swolchok commented 4 years ago

Thanks for pitching in!

My high-level feedback is that I don't think that there is enough demand for binaries for this tool to make it worth the time spent reviewing and maintaining infrastructure to ship them. For example, brew info fastmod on my Mac tells me that 1) a homebrew formula for fastmod exists (wow!) and 2) it doesn't see much usage -- 13 installs in last 30 days, 56 in last 90 days, 116 in last 365 days. I can't find packages for Debian/Ubuntu or Windows at all with some quick Googling.

In the event that we do change course and decide to do this, I don't think we should add CHANGELOG.md. To make sure I'm not off-base on this, I checked 6 other notable Facebook projects, and none of them have CHANGELOG.md:

https://github.com/facebook/buck https://github.com/facebook/folly https://github.com/facebook/hhvm https://github.com/facebook/rocksdb https://github.com/facebook/redex https://github.com/facebook/react