facebookincubator / fastmod

A fast partial replacement for the codemod tool

Apache License 2.0

1.68k stars 42 forks source link

Introducing flag to unescape subst string #42

Open assarbad opened 1 year ago

assarbad commented 1 year ago

This introduces the -S / --subst-escapes flag which will unescape the substitution string prior to performing the substitution.
Allows to work without the help of a shell or with shells incapable of passing substitution string arguments with certain special characters.
Special characters implemented are \t, \n, \r, '\ ' (blank space), \", \$, \', \\, \`
Added test cases for the newly added code.
Bumped the version number in Cargo.toml

It's a new flag so as not to break backwards compatibility.

If merged, this addresses #13 and #31.

If any changes are required, please advise and I will resubmit by force-pushing another signed commit.

facebook-github-bot commented 1 year ago

Hi @assarbad!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

assarbad commented 1 year ago

Signed the CLA.

assarbad commented 1 year ago

Sorry, had forgotten to run cargo fmt on the code. This was done with the latest change.

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 6 months ago

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

swolchok commented 6 months ago

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

the import failed due to conflicts

assarbad commented 6 months ago

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

the import failed due to conflicts

@swolchok Yep, maybe you can hold it for a bit. I'd like to address whatever review comments you say you had, then recommit (i.e. amend). Alas, they're not visible to me (see also other comment on #13 ... may take a few more minutes to finish).