facebookincubator / fbjni

A library designed to simplify the usage of the Java Native Interface
Apache License 2.0
266 stars 47 forks source link

Fix bug: package com.facebook.soloader.nativeloader does not exist #59

Open psionic12 opened 3 years ago

psionic12 commented 3 years ago

When loading jni libraries which used fbjni, such as writing like this: System.loadLibrary("mylib"); there will be a crash said that NativeLoader has not been initialized. To use standard native library loading, call NativeLoader.init(new SystemDelegate()). Since NativeLoader is in package com.facebook.soloader:nativeloader, which is hidden from the user, a user have to manually import this module.

Motivation

Why are you making this change?

Summary

What did you change?

How does the code work?

Why did you choose this approach?

Test Plan

How did you test this change? Any change that adds functionality should add a unit test as well.

facebook-github-bot commented 3 years ago

Hi @psionic12!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

psionic12 commented 3 years ago

@passy can you help to review if this pr is reasonable?