Closed mrousavy closed 9 months ago
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
What's the linter complaining about? Probably the long line in littleEndian()
? Can I run this locally?
What's the linter complaining about? Probably the long line in
littleEndian()
? Can I run this locally?
It's a clang formatting issue. I've reformatted it for you and scheduled a land.
Will need also a new release of fbjni if you need to use this. If you could do the bump to NDK 26.1 similarly to how I did on https://github.com/facebook/react-native/pull/42656 would be extremely helpful 👍 so we can get a new release out soon
Thanks! & sure, I'll do that tmrw :)
@cortinico merged this pull request in facebookincubator/fbjni@0454714cf0692c4efdb49a94d29d5d8f11667bbc.
Motivation
JByteBuffer
s could only be initialized withnativeOrder
endianness. With this PR, bothlittleEndian()
andbigEndian()
fields are exposed inJByteOrder
and can now be set throughJByteBuffer::order(...)
.Summary
Get static fields
LITTLE_ENDIAN
andBIG_ENDIAN
throughJByteOrder
.Test Plan
Test code:
Default:
With custom Endian: