facebookincubator / fizz

C++14 implementation of the TLS-1.3 standard
Other
1.13k stars 158 forks source link

Fix build failure with CMake #116

Closed carlocab closed 4 months ago

carlocab commented 4 months ago

Without this, the build fails with

  Undefined symbols for architecture arm64:
    "fizz::extensions::generateDelegatedCredentialPEM(fizz::extensions::DelegatedCredential, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >)", referenced from:
        fizz::tool::fizzGenerateDelegatedCredentialCommand(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) in FizzGenerateDelegatedCredentialCommand.cpp.o
  ld: symbol(s) not found for architecture arm64
  clang: error: linker command failed with exit code 1 (use -v to see invocation)

This was missed in 19dca4cbe227ad621be1b7bce916840a1b77b12c.

See https://github.com/Homebrew/homebrew-core/actions/runs/8932339958/job/24536092094?pr=170668#step:3:326

facebook-github-bot commented 4 months ago

@mingtaoy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 4 months ago

@mingtaoy merged this pull request in facebookincubator/fizz@b21c61965cdfa019101e964c1a206f74e5832ee9.