search

facebookincubator / fizz

C++14 implementation of the TLS-1.3 standard
Other
1.13k stars 158 forks source link

fix fizz build on arm64 #94

Closed ahornby closed 12 months ago

ahornby commented 1 year ago

fix fizz build on arm64

Summary:

Build was broken on arm64 ubuntu 22.04 due to unconditional use of aes/sse3 code

Used the same cmake logic as folly does to conditionally include the files on x86_64 only

Test Plan:

Local build with: ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. fizz

Before, broken:

cc: error: unrecognized command-line option ‘-maes’
cc: error: unrecognized command-line option ‘-mssse3’

After, works

Stack created with Sapling. Best reviewed with ReviewStack.

ahornby commented 12 months ago

alternative fix was merged in a5f718aecef5145845af61f792e6e17dbf0627bd