facebookincubator / flowtorch

This library would form a permanent home for reusable components for deep probabilistic programming. The library would form and harness a community of users and contributors by focusing initially on complete infra and documentation for how to use and create components.

https://flowtorch.ai

MIT License

301 stars 21 forks source link

Converted "Univariate Bijections" and "Multivariate Bijections" tutorials to Jupyter notebook #99

Closed stefanwebb closed 2 years ago

stefanwebb commented 2 years ago

Motivation

We would like to convert the two theory tutorials from MDX to Jupyter notebook format so that they can be directly run on Colab and locally, and be converted to MDX automatically by #94

Changes proposed

Convert:

/website/docs/users/univariate.mdx to /tutorials/univariate_bijections.ipynb
/website/docs/users/multivariate.mdx to /tutorials/multivariate_bijections.ipynb

Test Plan

Run these two tutorials in Jupyter notebook locally

stefanwebb commented 2 years ago

Currently in progress. I'm looking for bugs in SplineAutoregressive in the process - I've had trouble training other datasets using this type of flow

codecov-commenter commented 2 years ago

Codecov Report

Merging #99 (707f27b) into main (45e91ca) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files           6        6           
  Lines         227      227           
=======================================
  Hits          223      223           
  Misses          4        4

Flag	Coverage Δ
unittests	`98.23% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45e91ca...707f27b. Read the comment docs.

stefanwebb commented 2 years ago

The notebook content is finished, although I confirmed that we introduced a bug into bijectors.Spline. I'll have to find and fix the bug in a separate PR and regenerate the plots in these notebooks. I think we can merge this before then though!

stefanwebb commented 2 years ago

100 should fix issues with training flows in these tutorials...

facebook-github-bot commented 2 years ago

@stefanwebb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.