search

facebookincubator / gloo

Collective communications library with various primitives for multi-machine training.
Other
1.23k stars 303 forks source link

[Store] Introduce optional append method. #357

Closed kumpera closed 1 year ago

kumpera commented 1 year ago

Append is an optional operation for stores. The semantics is to create or append the value to a given key.

Test plan:

It builds. This change was tested from PyTorch.

kumpera commented 1 year ago

Are existing test plans enough?

Yes, because we're not modifying exiting functionality.

The only implementations of the new store API will be in PT, so there isn't much to test here.

facebook-github-bot commented 1 year ago

@kumpera has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@kumpera merged this pull request in facebookincubator/gloo@c774e9e0fcc49402ad0b8ca344a16cc332a77a01.