search

facebookincubator / gloo

Collective communications library with various primitives for multi-machine training.
Other
1.23k stars 303 forks source link

[TCP/Buffer] Add missing header #397

Open Aidyn-A opened 6 days ago

Aidyn-A commented 6 days ago

The TOT compilation fails with:

FAILED: third_party/gloo/gloo/CMakeFiles/gloo.dir/transport/tcp/buffer.cc.o 
...
~/git/pytorch/third_party/gloo/gloo/transport/tcp/buffer.cc: In member function ‘virtual void gloo::transport::tcp::Buffer::send(size_t, size_t, size_t)’:
~/git/pytorch/third_party/gloo/gloo/transport/tcp/buffer.cc:130:53: error: ‘__NR_gettid’ was not declared in this scope
  130 |     std::cout << "[" << getpid() << ": " << syscall(__NR_gettid) << "] ";

due to missing sys/syscall.h header declaration in buffer.cc introduced in commit aeca18386713535f371ab0a969365d50bc505610.

Aidyn-A commented 6 days ago

cc @c-p-i-o

c-p-i-o commented 11 hours ago

oops sorry. I really need to go look at fixing the internal codemod here at facebook. Because internally we use a bazel like build, it seems to ignore build variations.

c-p-i-o commented 11 hours ago

Also, I'm trying to revive the CI via github workflows. Feel free to add any automation there - once I land #395, and #396