facebookincubator / infima

A UI framework that provides websites with the minimal CSS and JS needed to get started with building a modern responsive beautiful website
https://infima.dev
MIT License
408 stars 55 forks source link

fix: proper sizing for hr element #228

Closed lex111 closed 2 years ago

lex111 commented 2 years ago

Now the sizing for <hr> element is confusing: although it is set as 1px by default, but it is actually 2px because the top and bottom borders are summed.

github-actions[bot] commented 2 years ago

Size Change: +64 B (0%)

Total Size: 579 kB

Filename Size Change
./packages/core/dist/css/default-dark/default-dark-rtl.css 84.1 kB -17 B (0%)
./packages/core/dist/css/default-dark/default-dark-rtl.min.css 59 kB +33 B (0%)
./packages/core/dist/css/default-dark/default-dark.css 84 kB -17 B (0%)
./packages/core/dist/css/default-dark/default-dark.min.css 59 kB +33 B (0%)
./packages/core/dist/css/default/default-rtl.css 82 kB -17 B (0%)
./packages/core/dist/css/default/default-rtl.min.css 57.9 kB +33 B (0%)
./packages/core/dist/css/default/default.css 81.9 kB -17 B (0%)
./packages/core/dist/css/default/default.min.css 57.8 kB +33 B (0%)
ℹī¸ View Unchanged | Filename | Size | | :--- | :---: | | `./packages/core/dist/js/alerts.js` | 409 B | | `./packages/core/dist/js/alerts.min.js` | 409 B | | `./packages/core/dist/js/button-groups.js` | 267 B | | `./packages/core/dist/js/button-groups.min.js` | 267 B | | `./packages/core/dist/js/dropdowns.js` | 1.01 kB | | `./packages/core/dist/js/dropdowns.min.js` | 1.01 kB | | `./packages/core/dist/js/menu.js` | 2.4 kB | | `./packages/core/dist/js/menu.min.js` | 2.4 kB | | `./packages/core/dist/js/navbar.js` | 1.08 kB | | `./packages/core/dist/js/navbar.min.js` | 1.08 kB | | `./packages/core/dist/js/pills.js` | 270 B | | `./packages/core/dist/js/pills.min.js` | 270 B | | `./packages/core/dist/js/radio-behavior.js` | 705 B | | `./packages/core/dist/js/radio-behavior.min.js` | 705 B | | `./packages/core/dist/js/tabs.js` | 267 B | | `./packages/core/dist/js/tabs.min.js` | 267 B |

compressed-size-action

github-actions[bot] commented 2 years ago

Dist CSS Diff

diff --git a/packages/core/dist/css/default/default.css b/packages/core/dist-branch/css/default/default.css
index 7055171..b4d0782 100644
--- a/packages/core/dist/css/default/default.css
+++ b/packages/core/dist-branch/css/default/default.css
@@ -1285,9 +1285,8 @@ blockquote > :last-child {
 /* Horizontal Rules */

 hr {
-  border-color: var(--ifm-hr-border-color);
-  border-style: solid;
-  border-width: var(--ifm-hr-border-width);
+  border: 0 solid var(--ifm-hr-border-color);
+  border-top-width: var(--ifm-hr-border-width);
   margin: var(--ifm-hr-margin-vertical) 0;
 }
netlify[bot] commented 2 years ago

Deploy Preview for infima ready!

Name Link
Latest commit c79cf28a22a76a46cc8fee837044903d49e7507f
Latest deploy log https://app.netlify.com/sites/infima/deploys/623d7ac6a2d6e20008c655b8
Deploy Preview https://deploy-preview-228--infima.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

slorber commented 2 years ago

agree 1px looks better and it's more intuitive to customize 👍