Logo not loading in 'Multi-Column' example for footer

facebookincubator / infima

A UI framework that provides websites with the minimal CSS and JS needed to get started with building a modern responsive beautiful website

https://infima.dev

MIT License

408 stars 55 forks source link

Logo not loading in 'Multi-Column' example for footer #239

Closed iammati closed 2 years ago

iammati commented 2 years ago

URL: https://infima.dev/docs/components/footer The logo isn't loading and you guys may want to change the "2019" to something more dynamic in all three examples (Simple, Multi-Column and Dark) :)

PS: Logo also affects to the "Dark" section right below

Josh-Cena commented 2 years ago

Thanks for the report. The broken image looks worth fixing, but the copyright is by design, because we are only demonstrating static markup.

There are two problems here: (1) we shouldn't use src="img/fb-oss-dark.png" because that's relative to the current URL instead of relative to the root (2) the image simply doesn't exist.

@yangshun Do you have the image for fb-oss-dark.png? I only have the version meant to be used on dark backgrounds.

slorber commented 2 years ago

I don't think I ever saw a variant supposed to be displayed on light background

also received new Meta assets from Joel and there's no asset to be displayed on light background either

This one is likely the one we'll start using in the future:

Meta_lockup_negative_primary_RGB

slorber commented 2 years ago

FYI those are all the pngs I got from Joel: Meta_lockup_positive_primary_RGB Meta_lockup_negative_primary_RGB Meta_lockup_mono_black_RGB Meta_lockup_mono_white_RGB

(Also have SVG/AI)

Josh-Cena commented 2 years ago

The first and the third are for light background because they are obviously too dark for the dark background.

Josh-Cena commented 2 years ago

Geez these images are legit making my browser lag...

iammati commented 2 years ago

Geez these images are legit making my browser lag...

Same here lol you guys should maybe investigate into that since those images shouldn't cause a browser to lag that much at all 🤣 btw I'm using Brave 1.38.111 Chromium: 101.0.4951.54 (official build) (64-bit)

Josh-Cena commented 2 years ago

Each of these images is ~2MB, and 29000px (!) wide, I'm not surprised

They'd better give SVGs directly...

iammati commented 2 years ago

XDD

Josh-Cena commented 2 years ago

I've collapsed the comment so we can take a breath

Josh-Cena commented 2 years ago

About fixing this issue, I will wait a while, because seems none of the other Facebook sites have changed yet (?), so I'm not sure which direction we are moving in

iammati commented 2 years ago

Alright. Thanks for taking care of that insane loading times, though quite hilarious